Matthias Clasen [Fri, 15 Jan 2021 15:56:37 +0000 (15:56 +0000)]
Merge branch 'macos-ci-cairo' into 'master'
Revert "Fix the cairo build on OS X"
See merge request GNOME/gtk!3080
Matthias Clasen [Fri, 15 Jan 2021 14:06:46 +0000 (09:06 -0500)]
Revert "Fix the cairo build on OS X"
This reverts commit
710ef00dfea4853d99e1c7f7201733d81d2b846d.
The cairo change has been merged.
Marek Černocký [Fri, 15 Jan 2021 13:10:17 +0000 (14:10 +0100)]
Updated Czech translation
Matthias Clasen [Fri, 15 Jan 2021 05:48:00 +0000 (05:48 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
See merge request GNOME/gtk!3078
Matthias Clasen [Fri, 15 Jan 2021 03:55:52 +0000 (22:55 -0500)]
Make HighContrastInverse a dark variant
Make HighContrastInverse available as the dark variant of HighContrast,
in addition to being a standalone theme. This regularizes our theme
variants, and doesn't hurt.
Matthias Clasen [Fri, 15 Jan 2021 03:41:43 +0000 (22:41 -0500)]
Make Adwaita-dark available as a theme
This makes Adwaita-dark available as a standalone
theme.
Matthias Clasen [Thu, 14 Jan 2021 18:33:45 +0000 (18:33 +0000)]
Merge branch 'wip/carlosg/mark-valid-portal-settings' into 'master'
gdk/wayland: Mark matched settings from the portal as valid
See merge request GNOME/gtk!3076
Carlos Garnacho [Thu, 14 Jan 2021 14:47:36 +0000 (15:47 +0100)]
gdk/wayland: Mark matched settings from the portal as valid
Commit
e6209de9625 added some checks on TranslationEntry.valid in
order to figure out whether using the new font settings or the
old g-s-d ones. However that's only set in the non-sandboxed case.
This makes sandboxed applications fallback to the old (and also
non-existing with modern g-s-d) settings, possibly resulting in
ugly defaults being picked.
Fix this by also marking TranslationEntry elements as valid when
using the settings portal, precisely those entries that we are able
to read and match with our own table.
Matthias Clasen [Thu, 14 Jan 2021 13:38:18 +0000 (13:38 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
See merge request GNOME/gtk!3075
Matthias Clasen [Thu, 14 Jan 2021 13:13:34 +0000 (08:13 -0500)]
docs: Fix a heading gotcha
One of the many migration guide sections was too
prominent.
Matthias Clasen [Thu, 14 Jan 2021 12:52:36 +0000 (07:52 -0500)]
doc: Clarify some migration hints
Don't mention GdkSurface::layout as replacement for
GtkWindow::configure-event. Instead, explain how to
save window state.
Daniel Mustieles [Thu, 14 Jan 2021 09:35:43 +0000 (10:35 +0100)]
Updated Spanish translation
Daniel Mustieles [Thu, 14 Jan 2021 09:35:35 +0000 (10:35 +0100)]
Updated Spanish translation
Christian Hergert [Wed, 13 Jan 2021 16:13:14 +0000 (16:13 +0000)]
Merge branch 'nacho/macos-stylus' into 'master'
Support stylus devices on macos
See merge request GNOME/gtk!3058
Anders Jonsson [Tue, 12 Jan 2021 21:55:52 +0000 (21:55 +0000)]
Update Swedish translation
Anders Jonsson [Tue, 12 Jan 2021 21:51:53 +0000 (21:51 +0000)]
Update Swedish translation
Emmanuele Bassi [Tue, 12 Jan 2021 16:50:31 +0000 (16:50 +0000)]
Merge branch 'ebassi/aspect-frame-doc' into 'master'
Ebassi/aspect frame doc
See merge request GNOME/gtk!3073
Matthias Clasen [Tue, 12 Jan 2021 15:50:41 +0000 (10:50 -0500)]
Remove a misleading comment
Matthias Clasen [Tue, 12 Jan 2021 14:04:51 +0000 (14:04 +0000)]
Merge branch 'dist-css' into 'master'
dist: Add a dist script to generate css
See merge request GNOME/gtk!3074
Matthias Clasen [Tue, 12 Jan 2021 13:18:47 +0000 (08:18 -0500)]
dist: Add a dist script to generate css
When I added the sassc option, I failed to ensure that
the theme css is included in the tarballs. This is required
to make tarball builds with -Dsassc=disabled work.
Emmanuele Bassi [Tue, 12 Jan 2021 12:37:31 +0000 (12:37 +0000)]
Merge branch 'ebassi/atspi-path-sanitize' into 'master'
a11y: Fix leak
See merge request GNOME/gtk!3072
Emmanuele Bassi [Tue, 12 Jan 2021 12:28:18 +0000 (12:28 +0000)]
Document limits of gtk_aspect_frame_get_ratio()
The GtkAspectFrame:ratio getter will return the value set, not the
actual ratio computed in case GtkAspectFrame:obey-child is TRUE.
Emmanuele Bassi [Tue, 12 Jan 2021 12:28:00 +0000 (12:28 +0000)]
Document GtkAspectFrame properties
Emmanuele Bassi [Tue, 12 Jan 2021 12:23:14 +0000 (12:23 +0000)]
docs: GtkAspectFrame is not a GtkFrame any more
Emmanuele Bassi [Tue, 12 Jan 2021 12:00:51 +0000 (12:00 +0000)]
a11y: Fix leak
Introduced by me in commit
03b60a2d5e40da1b137117aba05a2c818edd09b3.
Emmanuele Bassi [Tue, 12 Jan 2021 11:36:52 +0000 (11:36 +0000)]
Merge branch 'ebassi/atspi-path-sanitize' into 'master'
a11y: Sanitize the AT-SPI object path further
See merge request GNOME/gtk!3071
Emmanuele Bassi [Tue, 12 Jan 2021 11:15:28 +0000 (11:15 +0000)]
a11y: Sanitize the AT-SPI object path further
When falling back to g_get_prgname(), we need to take into account that
the program name may be the full argv[0] path, which will end up messing
the DBus object path.
Benjamin Otte [Mon, 11 Jan 2021 23:13:21 +0000 (23:13 +0000)]
Merge branch 'about-dialog-icon-size' into 'master'
About dialog icon size
See merge request GNOME/gtk!3070
Matthias Clasen [Mon, 11 Jan 2021 21:37:55 +0000 (16:37 -0500)]
iconhelper: Recreate the texture when needed
When the icon size changes, we want to reload themed
icons.
This was showing up as the GtkImage in about dialogs
getting a big size with the same small icon upon
changing -gtk-icon-size in the inspector.
Matthias Clasen [Mon, 11 Jan 2021 21:43:19 +0000 (16:43 -0500)]
Adwaita: Make about dialog icons big
Use 128 as the icon size for the image widget
in about dialogs.
Matthias Clasen [Mon, 11 Jan 2021 22:49:08 +0000 (17:49 -0500)]
aboutdialog: Set icon-size for the logo
Make it explicit that we want large icons here.
Matthias Clasen [Mon, 11 Jan 2021 21:48:06 +0000 (16:48 -0500)]
aboutdialog: Set a style class
Add the .aboutdialog style class to toplevel
widget of about dialogs, similar to what we
do for e.g. GtkAssistant.
Matthias Clasen [Mon, 11 Jan 2021 19:38:18 +0000 (14:38 -0500)]
about dialog: Remove manual icon sizing
We have icon theme code to do that for us.
Matthias Clasen [Mon, 11 Jan 2021 22:04:52 +0000 (22:04 +0000)]
Merge branch 'wip/kalev/gcc-11' into 'master'
Avoid diagnostics for gcc-11 false positive out of bounds accesses
See merge request GNOME/gtk!3064
Emmanuele Bassi [Mon, 11 Jan 2021 16:44:00 +0000 (16:44 +0000)]
Merge branch 'wip/fl/glrenderer-fixes' into 'master'
gl renderer: print fragment shader info
See merge request GNOME/gtk!3069
Kalev Lember [Sun, 10 Jan 2021 08:35:40 +0000 (09:35 +0100)]
Avoid diagnostics for gcc-11 false positive out of bounds accesses
This is a patch by Jeff Law <law@redhat.com> done in downstream Fedora
to fix the build with gcc 11.
Jakub Steiner [Mon, 11 Jan 2021 16:09:08 +0000 (16:09 +0000)]
Merge branch 'wip/jimmac/adjust-for-contemporary-trends' into 'master'
Wip/jimmac/adjust for contemporary trends
Closes #3568 and #3560
See merge request GNOME/gtk!3060
Fabio Lagalla [Mon, 11 Jan 2021 16:06:03 +0000 (17:06 +0100)]
gl renderer: print fragment shader info
It was logged twice the vertex shader info, instead
Jakub Steiner [Mon, 11 Jan 2021 15:18:47 +0000 (16:18 +0100)]
Adwaita: update image assets
- reflect button styling
- ignore backdrop for non buttons
Matthias Clasen [Mon, 11 Jan 2021 15:07:40 +0000 (15:07 +0000)]
Merge branch 'otte/for-master2' into 'master'
Remove guarantees we do not intend to hold
See merge request GNOME/gtk!3066
Jakub Steiner [Mon, 11 Jan 2021 15:00:32 +0000 (16:00 +0100)]
Adwaita: scales border
- remove -alt specialcasing for a straight forward border like
everything else and avoid broken :dark and HC
Matthias Clasen [Mon, 11 Jan 2021 14:44:27 +0000 (14:44 +0000)]
Merge branch 'fix-tablet-4' into 'master'
Wayland: ignore touch/tablet events on destroyed surfaces [GTK4]
See merge request GNOME/gtk!3065
Jakub Steiner [Mon, 11 Jan 2021 14:37:58 +0000 (14:37 +0000)]
Merge branch 'wip/jimmac/undercorated-active' into 'master'
Adwaita: less dramatic :active for undecorated buttons
Closes #3575
See merge request GNOME/gtk!3068
Jakub Steiner [Mon, 11 Jan 2021 14:00:38 +0000 (15:00 +0100)]
Adwaita: less dramatic :active for undecorated buttons
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3575
Jakub Steiner [Mon, 11 Jan 2021 13:08:57 +0000 (14:08 +0100)]
Adwaita: fix button border logic
- tint borders dark on non default / blue / red buttons
- just use plain $borders_color otherwise
- fixes HC/HCi
- ditch -alt buttons
Jakub Steiner [Fri, 8 Jan 2021 21:34:28 +0000 (22:34 +0100)]
Adwaita: flatter, lighter buttons
- lighten up for contrast, less of an oldschool gradient
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3568
Jakub Steiner [Fri, 8 Jan 2021 21:25:33 +0000 (22:25 +0100)]
Adwaita: round progress and levelbars
Jakub Steiner [Fri, 8 Jan 2021 21:12:41 +0000 (22:12 +0100)]
Adwaita: :checked:active and checked:hover states
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3560
Jakub Steiner [Fri, 8 Jan 2021 20:56:14 +0000 (21:56 +0100)]
Adwaita: flat scales, progressbars and level bars
Jakub Steiner [Fri, 8 Jan 2021 20:03:30 +0000 (21:03 +0100)]
Adwaita: remove edge highlights
- flat is the name of the game
- kids scream make it flat
- simplify mixins
Carlos Garnacho [Mon, 11 Jan 2021 12:07:01 +0000 (12:07 +0000)]
Merge branch 'avoid-pointer-reset-gtk4' into 'master'
wayland: avoid set_cursor() when unchanged or invisible
Closes #3350
See merge request GNOME/gtk!3062
Matthias Clasen [Mon, 11 Jan 2021 11:56:42 +0000 (11:56 +0000)]
Merge branch 'surface.compute.win32' into 'master'
Fix surface and geometry computation for Windows (Win32)
Closes #3480
See merge request GNOME/gtk!3067
Ignacio Casal Quinteiro [Thu, 7 Jan 2021 12:40:12 +0000 (13:40 +0100)]
Support stylus devices on macos
Chun-wei Fan [Thu, 31 Dec 2020 08:36:41 +0000 (16:36 +0800)]
gdk/win32: Fix window display and resizing
Have an implementation of ->request_layout() and ->compute_size() for the Win32
surface backend so that we can properly display and move and resize the
windows, as we request from the Win32 APIs.
Hxndling Aerosnap properly is mostly done except for snap_up(), which needs to
to be looked at later.
Chun-wei Fan [Thu, 31 Dec 2020 09:27:40 +0000 (17:27 +0800)]
gdk/win32: Rename 'margins' to 'shadow'
This improves consistency for the code.
Chun-wei Fan [Fri, 11 Dec 2020 02:37:43 +0000 (10:37 +0800)]
gdkwin32-surface.c: Fix return type
gdk_win32_toplevel_present() should now be returning nothing, not a gboolean.
Chun-wei Fan [Fri, 11 Dec 2020 02:29:28 +0000 (10:29 +0800)]
gdksurface-win32.c: Decouple mapped state from surface creation
In line with what is done with the Wayland backend, enable the mapped state
independently as needed from the toplevel surface presentation, and also enable
the mapped state if necessary when presenting the popup surface.
Benjamin Otte [Sun, 10 Jan 2021 21:37:03 +0000 (21:37 +0000)]
Remove guarantees we do not intend to hold
The fact that we are using gdk-pixbuf for loading files currrently does not mean we will use it going forward.
Also, "anything gdk-pixbuf can load" does not mean anything, because what gdk-pixbuf can load is a compile-time option.
As new_from_resource() will assert() if it cannot load a resource, we must be very sure that people do not use anything but PNG and JPEG for resources and the docs were not clear on that.
Asier Sarasua Garmendia [Sun, 10 Jan 2021 18:00:26 +0000 (18:00 +0000)]
Update Basque translation
Asier Sarasua Garmendia [Sun, 10 Jan 2021 17:59:56 +0000 (17:59 +0000)]
Update Basque translation
Piotr Drąg [Sun, 10 Jan 2021 17:27:55 +0000 (18:27 +0100)]
Update Polish translation
wisp3rwind [Wed, 11 Nov 2020 09:12:26 +0000 (10:12 +0100)]
Wayland: ignore touch/tablet events on destroyed surfaces
When destroying a wl_surface (e.g. when a window or menu is closed), the
surface may continue to exist in the compositor slightly longer than on
the client side. In that case, the surface can still receive input
events, which need to be ignored gracefully.
In particular, this prevents segfaulting on wl_surface_get_user_data()
in that situation.
Reported in
https://gitlab.gnome.org/GNOME/gtk/-/issues/3296
The same issue for pointers/keyboards was reported in
https://bugzilla.gnome.org/show_bug.cgi?id=693338
and fixed with in
bfd7137ffbcbd8caa531d7a47d799fefb6605a5a
3625f17857328ae7e7aa43340f29efa56575a7b0
a8fc099a725543649fe3aab76943c14bdcd860fc
wisp3rwind [Fri, 13 Nov 2020 12:01:56 +0000 (13:01 +0100)]
wayland: avoid set_cursor() when unchanged or invisible
In pointer_surface_update_scale(), only rescale the cursor surface when
the scale has actually changed and the cursor is on at least one output.
fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3350
Right now, this issue is not completely understood, so it might also
involve some questionable handling of cursor surface by sway/wlroots.
However, irrespective of that issue, this patch avoids unnecessary calls to the
compositor, and there should be no drawback: Whenever the pointer enters
a new output, pointer_surface_update_scale() will be called again, such
that correct scaling of the cursor is still ensured.
There is a slight difference: When the cursor leaves the last output,
previously the image was reset to scale factor 1. Now, it keeps whatever
was last. That might be more sensible than the previous behaviour,
assuming that it's likely that when the cursor enter an output again, it
has the same scaling. Alternatively, if one cares about resource usage
at this level, it might make more sense to destroy the surface than
rescaling to 1.
Matthias Clasen [Sat, 9 Jan 2021 05:50:53 +0000 (00:50 -0500)]
4.0.1
Matthias Clasen [Sat, 9 Jan 2021 06:28:11 +0000 (01:28 -0500)]
build: Add a sassc feature
Add an option to disable css rebuilds. This allows
to build GTK from release tarballs (Which are including
the css) without a sassc dependency.
Matthias Clasen [Sat, 9 Jan 2021 03:56:59 +0000 (03:56 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
Closes #3565
See merge request GNOME/gtk!3061
Matthias Clasen [Sat, 9 Jan 2021 03:20:04 +0000 (22:20 -0500)]
droptarget: Some docs cleanups
Fixes #3565, among other things.
Chun-wei Fan [Wed, 30 Dec 2020 10:14:20 +0000 (18:14 +0800)]
gtkffmediafile.c: Use g_snprintf()
Visual Studio 2013 is just shy of being sufficiently C99-compliant to
build GTK master, as it did not support snprintf() in its CRT
implementation.
Use g_snprintf() to cover for this.
Chun-wei Fan [Wed, 30 Dec 2020 10:13:15 +0000 (18:13 +0800)]
gtk/gtksecurememoryprivate.h: Include glib.h
Some compilers somehow do not have `inline` defined, so include glib.h
to ensure that keyword is defined.`
Matthias Clasen [Wed, 6 Jan 2021 13:12:38 +0000 (08:12 -0500)]
a11y: Avoid __ prefixes for variable names
Seems that msvc does not like that.
Matthias Clasen [Sat, 9 Jan 2021 01:04:22 +0000 (01:04 +0000)]
Merge branch 'nacho/seatdefault' into 'master'
Clean ups in seat default
See merge request GNOME/gtk!3057
Ignacio Casal Quinteiro [Fri, 8 Jan 2021 12:11:56 +0000 (13:11 +0100)]
seatdefault: use g_clear_pointer to unref the tools
Ignacio Casal Quinteiro [Fri, 8 Jan 2021 12:10:56 +0000 (13:10 +0100)]
seatdefault: rename dispose method
Matthias Clasen [Thu, 7 Jan 2021 21:08:46 +0000 (21:08 +0000)]
Merge branch 'wip/nacho/associated-device' into 'master'
gdkdevice: use g_set_object to set the associated device
See merge request GNOME/gtk!3049
Matthias Clasen [Thu, 7 Jan 2021 18:37:28 +0000 (18:37 +0000)]
Merge branch 'mcatanzaro/company-unparent-warning' into 'master'
Add critical if widget has a parent during dispose
See merge request GNOME/gtk!3053
Matthias Clasen [Thu, 7 Jan 2021 18:35:37 +0000 (18:35 +0000)]
Merge branch 'mcatanzaro/unparent' into 'master'
Remove incorrect unparenting guidance from migration guide
See merge request GNOME/gtk!3050
Matthias Clasen [Thu, 7 Jan 2021 18:00:19 +0000 (18:00 +0000)]
Merge branch 'mcatanzaro/gtkbuilder-docs' into 'master'
Improve GtkBuilder documentation
See merge request GNOME/gtk!3055
Matthias Clasen [Thu, 7 Jan 2021 17:55:38 +0000 (17:55 +0000)]
Merge branch 'mcatanzaro/event-controller-porting-guide' into 'master'
Expand event controller API changes section of GTK 4 porting guide
See merge request GNOME/gtk!3054
Michael Catanzaro [Thu, 7 Jan 2021 15:42:08 +0000 (09:42 -0600)]
Remove incorrect unparenting guidance from migration guide
This rule is almost always wrong, and we're having some trouble agreeing
on replacement text. Let's remove the whole paragraph for now, to avoid
confusion.
Benjamin Otte [Thu, 7 Jan 2021 15:49:52 +0000 (09:49 -0600)]
Add critical if widget has a parent during dispose
This is a refcounting bug. Be very verbose about it instead of trying to
call a function that releases a reference to the widget without
references.
Michael Catanzaro [Thu, 7 Jan 2021 17:30:57 +0000 (11:30 -0600)]
gtkbuilder: fix recommendations that no longer make sense in GTK 4
In GTK 3, it was pretty much always better to use
gtk_builder_new_from_whatever() rather than
gtk_builder_add_from_whatever(). But in GTK 4, this is no longer
generally true. Let's add some context on when you want to use one or
the other.
Michael Catanzaro [Thu, 7 Jan 2021 17:18:34 +0000 (11:18 -0600)]
Add section on GtkBuilder API changes to GTK 4 migration guide
Thanks to Benjamin for helping with the language.
Emmanuele Bassi [Thu, 7 Jan 2021 17:17:44 +0000 (17:17 +0000)]
Merge branch 'ebassi/ci-only' into 'master'
ci: Specify `only` for other jobs
See merge request GNOME/gtk!3052
Michael Catanzaro [Thu, 7 Jan 2021 16:53:09 +0000 (10:53 -0600)]
Expand event controller API changes section of GTK 4 porting guide
There is more to say about changes to GtkEventController.
Emmanuele Bassi [Thu, 7 Jan 2021 16:14:04 +0000 (16:14 +0000)]
ci: Only run macOS job on upstream branches
Don't run CI on macOS for forks.
Emmanuele Bassi [Thu, 7 Jan 2021 16:03:10 +0000 (16:03 +0000)]
ci: Specify `only` for other jobs
Otherwise MRs will only run macOS jobs.
Ignacio Casal Quinteiro [Thu, 7 Jan 2021 15:13:39 +0000 (16:13 +0100)]
gdkdevice: use g_set_object to set the associated device
Matthias Clasen [Thu, 7 Jan 2021 13:42:42 +0000 (13:42 +0000)]
Merge branch 'wip/jimmac/flat-buttons' into 'master'
Adwaita: fine tune flat button styling
Closes #3481
See merge request GNOME/gtk!3046
Matthias Clasen [Thu, 7 Jan 2021 13:41:40 +0000 (13:41 +0000)]
Merge branch 'wip/jimmac/hc-switch-border' into 'master'
HC: switch border color
Closes #3460
See merge request GNOME/gtk!3048
Matthias Clasen [Thu, 7 Jan 2021 13:25:11 +0000 (13:25 +0000)]
Merge branch 'wip/nacho/tool-api' into 'master'
seat: improve api to take into account the tool type
See merge request GNOME/gtk!3047
Ignacio Casal Quinteiro [Thu, 7 Jan 2021 11:27:26 +0000 (12:27 +0100)]
seat: improve api to take into account the tool type
Otherwise if we have several tools with the same serial
and hardware id we might match the wrong tool.
Jakub Steiner [Thu, 7 Jan 2021 11:44:53 +0000 (12:44 +0100)]
HC: switch border color
- lighten inverted HC borders while darkening the regular/light variant
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3460
Jakub Steiner [Thu, 7 Jan 2021 11:12:55 +0000 (12:12 +0100)]
Adwaita: fine tune flat button styling
- enough contrast for hover and active, while noticably different in
normal nad headerbar context (and both light and dark variants).
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3481
Matthias Clasen [Wed, 6 Jan 2021 22:13:02 +0000 (22:13 +0000)]
Merge branch 'X11-surface' into 'master'
x11: fix crash on idle compute size without layout
See merge request GNOME/gtk!3031
Matthias Clasen [Wed, 6 Jan 2021 22:10:25 +0000 (22:10 +0000)]
Merge branch 'wip/exalm/headerbar' into 'master'
headerbar: Prepend start window controls instead of appending
See merge request GNOME/gtk!3044
Jordi Mas [Wed, 6 Jan 2021 21:42:44 +0000 (22:42 +0100)]
Update Catalan translation
Alexander Mikhaylenko [Wed, 6 Jan 2021 17:04:55 +0000 (22:04 +0500)]
headerbar: Prepend start window controls instead of appending
Make sure they are always in the correct position.
Matthias Clasen [Wed, 6 Jan 2021 14:52:11 +0000 (14:52 +0000)]
Merge branch 'macos-ci' into 'master'
Macos ci
See merge request GNOME/gtk!3032
Matthias Clasen [Wed, 6 Jan 2021 14:40:36 +0000 (14:40 +0000)]
Merge branch 'wip/jimmac/headerbar-specialcasing' into 'master'
Adwaita: specialcase switches and scales for headerbars
Closes #3504
See merge request GNOME/gtk!3043
Matthias Clasen [Wed, 6 Jan 2021 14:36:02 +0000 (09:36 -0500)]
ci: Limit macos runs
We are building the full stack here, which is pretty expensive,
so only do it for merge requests and master.